Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: solve issue with checking folder existence using FTP #1838

Open
wants to merge 1 commit into
base: 3.x
Choose a base branch
from

Conversation

mhmmdtech
Copy link

fix: solve issue with checking folder existence using FTP

fix: solve issue with checking folder existence using FTP
@mhmmdtech
Copy link
Author

mhmmdtech commented Dec 11, 2024

I had a project that was developed with Laravel 7 and I upgraded it to Laravel 11.

In this process, I needed to install this package and use it to upload the file to the download host via FTP.

But I had a challenge in checking folder existence, and with changes in this commit, after each successful check of the folder path, if that folder exists, we will return to the original path and we are ready to check the new path.

also you can check this example in php documentaion

@mhmmdtech
Copy link
Author

@SamMousa
I would appreciate it if you could check the tests, I added two lines to the code and got an error in PHP 8.1. I even got the third error where I didn't add anything.
Is everything correct and is there something wrong with my code?

@SamMousa
Copy link

Code lgtm, i think the issue is in annotations of the provider @return resource

@mhmmdtech
Copy link
Author

I understand, but what confuses me is that my code works fine in your tests in PHP versions (8.0, 8.2, 8.3, and 8.4)

But I only get an error in version 8.1, please guide me more clearly. Do I need to change something else to add these two lines of code, which are even written in the PHP notes?

@SamMousa
Copy link

I don't have time to look into that; also I don't think it's needed. IMO we should just drop php 8.1 since it is EOL https://www.php.net/supported-versions.php

I'm merely a contributor here so I don't decide these things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants